Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(oxc_transformer): define works differently with esbuild #7593

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Dec 3, 2024

See #7594

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 3, 2024
@sapphi-red sapphi-red changed the title test: define works differently with esbuild test(oxc_transformer): define works differently with esbuild Dec 3, 2024
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Dec 3, 2024
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7593 will not alter performance

Comparing sapphi-red:test/add-define-incompatible-with-esbuild (857754d) with main (16adaf9)

Summary

✅ 30 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY force-pushed the test/add-define-incompatible-with-esbuild branch from 4700a00 to 857754d Compare December 3, 2024 07:03
@IWANABETHATGUY IWANABETHATGUY merged commit 71b3437 into oxc-project:main Dec 3, 2024
26 checks passed
@sapphi-red sapphi-red deleted the test/add-define-incompatible-with-esbuild branch December 4, 2024 03:12
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants