Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minifier): improve ast passes #7518

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 28, 2024

No description provided.

Copy link

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 28, 2024
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #7518 will degrade performances by 36.94%

Comparing 11-28-refactor_minifier_improve_ast_passes (625a5ba) with main (cc078d6)

Summary

❌ 3 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 11-28-refactor_minifier_improve_ast_passes Change
minifier[antd.js] 151 ms 222.1 ms -32%
minifier[react.development.js] 1.4 ms 2.1 ms -33.1%
minifier[typescript.js] 241.8 ms 383.5 ms -36.94%

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
Copy link
Member Author

Boshen commented Nov 28, 2024

Merge activity

  • Nov 28, 4:30 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 28, 4:30 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 28, 4:38 AM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason.
  • Nov 28, 5:29 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 28, 5:29 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 28, 5:30 AM EST: A user merged this pull request with the Graphite merge queue.

Boshen added a commit that referenced this pull request Nov 28, 2024
@Boshen Boshen force-pushed the 11-28-refactor_minifier_improve_ast_passes branch from 79021e3 to 63cc265 Compare November 28, 2024 09:31
@Boshen Boshen force-pushed the 11-28-refactor_minifier_improve_ast_passes branch from 63cc265 to 625a5ba Compare November 28, 2024 09:33
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
@graphite-app graphite-app bot merged commit 625a5ba into main Nov 28, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 11-28-refactor_minifier_improve_ast_passes branch November 28, 2024 10:30
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant