refactor(transformer/class-properties): remove a branch from transform_call_expression_impl
#7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
|
Tiny change, so merging without review. |
Merge activity
|
…rm_call_expression_impl` (#7507) Small optimization. `transform_call_expression_impl` does not require the `Expression::CallExpression`, only the `CallExpression` itself. So pass that into the function, instead of having to unwrap it (which is an unnecessary branch).
overlookmotel
force-pushed
the
11-27-refactor_transformer_class-properties_remove_a_branch_from_transform_call_expression_impl_
branch
from
842c76b to
5261547
Compare
graphite-app
bot
deleted the
11-27-refactor_transformer_class-properties_remove_a_branch_from_transform_call_expression_impl_
branch
CodSpeed Performance ReportMerging #7507 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization.
transform_call_expression_impldoes not require theExpression::CallExpression, only theCallExpressionitself. So pass that into the function, instead of having to unwrap it (which is an unnecessary branch).