Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(diagnostics): configure miette properly and remove customization code #1791

Closed
wants to merge 1 commit into from

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 23, 2023

This is also an effort to remove 0.5s of terminal checking system calls across all threads.

To fully remove all system calls that check the terminal, these 2 PRs are required:

@github-actions github-actions bot added the A-cli Area - CLI label Dec 23, 2023
@Boshen Boshen marked this pull request as ready for review December 23, 2023 15:58
@Boshen Boshen marked this pull request as draft December 23, 2023 16:14
@Boshen
Copy link
Member Author

Boshen commented Dec 23, 2023

My customization changed the title color to yellow, this PR reverted that

image

@Boshen
Copy link
Member Author

Boshen commented Dec 23, 2023

let title = format!("{}", diagnostic.to_string().style(severity_style));
let title = textwrap::fill(&title, opts);
writeln!(f, "{}", title)?;

Not achievable.

@Boshen Boshen closed this Dec 23, 2023
@camc314 camc314 deleted the refactor-miette branch December 23, 2023 18:05
@camc314 camc314 restored the refactor-miette branch December 23, 2023 18:05
@camc314 camc314 deleted the refactor-miette branch December 28, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant