fixup! feat(linter): Implement iframe-has-title rule for jsx_a11y plugin

oxc-project · Dec 2, 2023 · 77033a4 · 77033a4
1 parent 7334857
commit 77033a4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/iframe_has_title.rs b/crates/oxc_linter/src/rules/jsx_a11y/iframe_has_title.rs
@@ -78,7 +78,7 @@ impl Rule for IframeHasTitle {
         let alt_prop = if let Some(prop) = has_jsx_prop_lowercase(jsx_el, "title") {
             prop
         } else {
-            ctx.diagnostic(IframeHasTitleDiagnostic(jsx_el.span));
+            ctx.diagnostic(IframeHasTitleDiagnostic(iden.span));
             return;
         };
 
@@ -115,7 +115,7 @@ impl Rule for IframeHasTitle {
             _ => {}
         }
 
-        ctx.diagnostic(IframeHasTitleDiagnostic(jsx_el.span));
+        ctx.diagnostic(IframeHasTitleDiagnostic(iden.span));
     }
 }
 

diff --git a/crates/oxc_linter/src/snapshots/iframe_has_title.snap b/crates/oxc_linter/src/snapshots/iframe_has_title.snap
@@ -2,66 +2,66 @@
 source: crates/oxc_linter/src/tester.rs
 expression: iframe_has_title
 ---
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe />
-   · ──────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.
 
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe {...props} />
-   · ─────────────────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.
 
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe title={undefined} />
-   · ────────────────────────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.
 
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe title='' />
-   · ───────────────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.
 
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe title={false} />
-   · ────────────────────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.
 
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe title={true} />
-   · ───────────────────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.
 
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe title={''} />
-   · ─────────────────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.
 
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe title={``} />
-   · ─────────────────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.
 
-  ⚠ eslint(iframe-has-title): Missing `title` attribute for the `iframe` element.
+  ⚠ eslint-plugin-jsx-a11y(iframe-has-title): Missing `title` attribute for the `iframe` element.
    ╭─[iframe_has_title.tsx:1:1]
  1 │ <iframe title={42} />
-   · ─────────────────────
+   ·  ──────
    ╰────
   help: Provide title property for iframe element.