Skip to content

Commit

Permalink
refactor(linter): react/jsx_no_undef rule get_member_ident do not…
Browse files Browse the repository at this point in the history
… return Option (#5411)

Small tidy-up after #5358. `get_member_ident` now always returns a value, never `None`, so no need for it to return an `Option`.
  • Loading branch information
overlookmotel committed Sep 2, 2024
1 parent 1aa49af commit 2ccbd93
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions crates/oxc_linter/src/rules/react/jsx_no_undef.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ fn get_resolvable_ident<'a>(node: &'a JSXElementName<'a>) -> Option<&'a Identifi
match node {
JSXElementName::Identifier(_) | JSXElementName::NamespacedName(_) => None,
JSXElementName::IdentifierReference(ref ident) => Some(ident),
JSXElementName::MemberExpression(expr) => get_member_ident(expr),
JSXElementName::MemberExpression(expr) => Some(get_member_ident(expr)),
}
}

fn get_member_ident<'a>(mut expr: &'a JSXMemberExpression<'a>) -> Option<&'a IdentifierReference> {
fn get_member_ident<'a>(mut expr: &'a JSXMemberExpression<'a>) -> &'a IdentifierReference {
loop {
match &expr.object {
JSXMemberExpressionObject::IdentifierReference(ident) => return Some(ident),
JSXMemberExpressionObject::IdentifierReference(ident) => return ident,
JSXMemberExpressionObject::MemberExpression(next_expr) => {
expr = next_expr;
}
Expand Down

0 comments on commit 2ccbd93

Please sign in to comment.