Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more fields in tsconfig#CompilerOptionsSerde #374

Merged

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Feb 12, 2025

related issues:

  1. [Bug]: passes TypeScript experimental decorators as-is rolldown/rolldown#2296
  2. [Bug]: Rolldown is not honouring jsxImportSource in tsconfig.json rolldown/rolldown#3473

These issues require rolldown read the tsconfig.json and merge related options to oxc-transform

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review February 12, 2025 08:40
Copy link
Contributor Author

IWANABETHATGUY commented Feb 12, 2025

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (f7a3773) to head (c8320bd).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #374   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files          13       13           
  Lines        2604     2604           
=======================================
  Hits         2490     2490           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #374 will not alter performance

Comparing 02-12-feat_add_more_fields_in_tsconfig_compileroptionsserde (c8320bd) with main (f7a3773)

Summary

✅ 3 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-feat_add_more_fields_in_tsconfig_compileroptionsserde branch from ebe6a3d to c8320bd Compare February 12, 2025 08:44
@Boshen Boshen self-assigned this Feb 12, 2025
@Boshen Boshen merged commit 06e2113 into main Feb 14, 2025
17 checks passed
@Boshen Boshen deleted the 02-12-feat_add_more_fields_in_tsconfig_compileroptionsserde branch February 14, 2025 10:04
@oxc-bot oxc-bot mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants