feat!: PackageJson and TsConfig traits
#360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #360 will not alter performanceComparing Summary
|
arendjr
commented
Jan 18, 2025
Boshen
approved these changes
Jan 18, 2025
Boshen
reviewed
Jan 18, 2025
|
Biome PR seems to be coming along well, so I think from our side this is good 👍 See: biomejs/biome#4929 |
Boshen
changed the title
PackageJson and TsConfig traits PackageJson and TsConfig traits
This was referenced Feb 10, 2025
Closed
Merged
Boshen
pushed a commit
that referenced
this pull request
Feb 10, 2025
## 🤖 New release * `oxc_resolver`: 4.0.0 -> 4.0.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [4.0.0](oxc_resolver-v3.0.3...oxc_resolver-v4.0.0) - 2025-01-20 ### <!-- 0 -->Features - [**breaking**] generic fs cache `type Resolver = ResolverGeneric<FsCache<FileSystemOs>>` (#358) - [**breaking**] `PackageJson` and `TsConfig` traits (#360) ### <!-- 2 -->Performance - use papaya instead of dashmap (#356) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
PackageJsonandTsConfigtraits. The old structs have been renamed toPackageJsonSerdeand TsConfigSerderespectively. Both are behind thefs_cachefeature flag now.serdeas a dependency has become optional and is only needed for thefs_cache` feature too.For now, I have opted not to replace the
FileSystem::read_to_string()method with trait-specific versions yet, since this functionality is now all encapsulated within theFsCache. Consumers that wish to use custom implementation of the manifest traits most likely want to use a custom cache altogether (I know this will be true for Biome at least), so I didn't see much reason for additional complexity and breaking changes there now.I'm still working on a Biome PoC based on this, so I'll keep the PR on Draft until I can verify everything works. Feedback is certainly already welcome!Update: See biomejs/biome#4929