Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(napi): align *Fields user options with enhanced-resolve #35

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

xc2
Copy link
Contributor

@xc2 xc2 commented Dec 17, 2023

hi there, new to rust.

this pr is to align user options of napi bindings below with https://github.com/webpack/enhanced-resolve/blob/58464fc7cb56673c9aa849e68e6300239601e615/types.d.ts#L486-L630

  • aliasFields
  • exportsFields
  • mainFields
  • modules

@xc2 xc2 changed the title chore(napi): align *Fields in UserResolveOptions with enhanced-resolve chore(napi): align *Fields user options with enhanced-resolve Dec 17, 2023
Copy link

codspeed-hq bot commented Dec 17, 2023

CodSpeed Performance Report

Merging #35 will not alter performance

Comparing xc2:napi-options-alignment (4539ede) with main (c4432a5)

Summary

✅ 2 untouched benchmarks

@Boshen Boshen merged commit bcbcceb into oxc-project:main Dec 18, 2023
@xc2 xc2 deleted the napi-options-alignment branch December 18, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants