Add add_to_top_level_lambda_param assist #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
oxalica
requested changes
Dec 4, 2022
figsoda
changed the title
figsoda
changed the title
oxalica
reviewed
Dec 4, 2022
| #[test] | ||
| fn simple() { | ||
| check("{ }: foo$0", expect!["{ foo }: foo"]); | ||
| check("{}: foo$0", expect!["{foo }: foo"]); |
There was a problem hiding this comment.
Seems kind of weird. Is this expected?
IMO, braces should always leave spaces inside. From this perspective, this is acceptable.
There was a problem hiding this comment.
I added the test just to check that the insert-before-space logic doesn't break anything. I don't think it looks good, but I also don't think the extra logic required is worth it for unconventional formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggests
{ }: foo->{ foo }: foorelated issue: #39