Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liveness warnings for __findFile #109

Closed
wants to merge 1 commit into from

Conversation

cab404
Copy link

@cab404 cab404 commented Sep 20, 2023

Search paths desugar to calling __findFile in Nix.

This fixes warnings in let __findFile = a: b: "hi ${b}!"; in <gilbert>

List parameter is added cause __findFile receives one (with NIXPATH or error thunk). Might be useful for type inference.

I am not sure, if accounting for such a hack is in scope of this lsp, but I've seen it being used and I am using it myself.

  • Fix "Undefined name"
  • Fix broken search path highlight ranges

Search paths desugar to calling __findFile in Nix.

List parameter is added cause __findFile receives one (with NIXPATH or error thunk).
Might be useful for type inference.
@cab404 cab404 marked this pull request as draft September 20, 2023 14:43
@cab404
Copy link
Author

cab404 commented Sep 20, 2023

This currently emits «Undefined name» warnings due to __findFile not being in scope. I probably should modify "generated.expr" generation, however I am not sure how to add primops without the use of tty yet

@oxalica oxalica closed this in 61caccd Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant