Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: use computed for props.loading when provide in resouceList #424

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Update: use computed for props.loading when provide in resouceList #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ResourceItem/ResourceItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ const checkboxAccessibilityLabel = computed(() => {
return props.name || props.accessibilityLabel || i18n.translate('Polaris.Common.checkbox');
});

const tabIndex = computed(() => loading ? -1 : 0);
const tabIndex = computed(() => loading?.value ? -1 : 0);

const ariaLabel = computed(() => {
return props.accessibilityLabel ||
Expand Down
2 changes: 1 addition & 1 deletion src/components/ResourceList/ResourceList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ provide<ResourceListContextType>('resource-list-context', {
selectedItems: selected,
selectMode: selectMode,
resourceName: props.resourceName,
loading: props.loading,
loading: computed(() => props.loading),
hasBulkActions: Boolean(props.bulkActions),
onSelectionChange: handleSelectionChange,
});
Expand Down
2 changes: 1 addition & 1 deletion src/utilities/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export interface ResourceListContextType {
plural: string;
};
hasBulkActions?: boolean;
loading?: boolean;
loading?: ComputedRef<boolean>;
onSelectionChange?(
selected: boolean,
id: string,
Expand Down