Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Select to use model instead of value for native select's binded value #387

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

cbodtorf
Copy link
Contributor

@cbodtorf cbodtorf commented Aug 8, 2024

See related Issue: #386

I noticed this in docs, as well as locally.

Visually it looks like the Select is working, but the native select element's value is being reset, or set to an empty string.

Only on the second time of clicking the option will it get set properly.
Kapture 2024-08-08 at 15 57 58

Changing :value="value" to :value="model" seems to get things working correctly. See below with the local docs being run.

Kapture 2024-08-08 at 18 10 27

@cbodtorf cbodtorf changed the title fix: update Select to use instead of for native select's binded value fix: update Select to use model instead of value for native select's binded value Aug 8, 2024
@juzser juzser self-requested a review August 12, 2024 02:14
@juzser juzser added the bug Something isn't working label Aug 12, 2024
@juzser juzser merged commit 5691cf6 into ownego:master Aug 12, 2024
@cbodtorf cbodtorf deleted the fix/select-target-value branch August 12, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants