Allow label, helpText, prefix and suffix as params
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…city fix: remove the requirement for autoComplete param on TextField
merge from master
… that also have them as slots
merge with remote
juzser
reviewed
Jul 12, 2022
| slot(name="prefix") | ||
| template(#suffix, v-if="slots.suffix") | ||
| slot(name="suffix") | ||
| template(#help-text, v-if="slots['help-text']" || helpText) |
| slot(name="help-text") | ||
| template(#label, v-if="slots.label || label") | ||
| slot(name="label" v-if="slots.label") | ||
| template(v-else-if="label") {{ label }} |
There was a problem hiding this comment.
I think we just need v-else here
| @@ -78,6 +85,8 @@ Labelled( | |||
| v-else, | |||
| :is="multiline ? 'textarea' : 'input'", | |||
| :id="id", | |||
| :label="label", | |||
There was a problem hiding this comment.
Nah, why do we need this prop here?
|
It's likely that I'm screwing up because I still don't quite understand pug - the rules coming over from HTML are a little ... different? Or I just don't read it as well. Yes, please make those small changes if you would, sorry. |
|
No worry, you did a good job, just small tweaks needed. I'm updating this feature together with migrating Polaris v9.20.0. |
|
I know it's hard writing an open source project. You want people to be involved so you don't have to do it all yourself but you also want very specific standards :D |
|
#155 solved this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
label,helpText,prefixandsuffixas params on components that have them as slots. The slots override the params.