[full-ci] Wording: Rename Quicklink to link #8898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookacat
changed the title
AlexAndBear
approved these changes
Apr 24, 2023
|
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35158/37/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkCreate_feature-L165.png |
lookacat
changed the title
lookacat
force-pushed
the
wording-rename-quicklink-to-link
branch
from
e8b55be to
f52c5d6
Compare
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35158/65/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkCreate_feature-L165.png |
kulmann
approved these changes
Apr 25, 2023
|
PR needs a rebase please :-) |
lookacat
force-pushed
the
wording-rename-quicklink-to-link
branch
from
be9e58a to
5ce5f96
Compare
|
Kudos, SonarCloud Quality Gate passed! |
SwikritiT
reviewed
Apr 27, 2023
Comment on lines
+175
to
176
| | name | Link | | ||
| And the following success message should be displayed on the webUI |
There was a problem hiding this comment.
due to this change the test is failing with latest ocis #8929. The then step asserts from an api call. So if I understand this correctly. The naming from QuickLink to link is just on the UI level and API stills responds with Quicklink?
There was a problem hiding this comment.
Yes, that was just a UI change.
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've renamed "Quicklink" to "link" in the UI
See #7891
Related Issue
Types of changes
Checklist: