-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDFViewer / CSP - frame-src object-src blob: #8498
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks for the contribution, works like a charm! 🥳
changelog/8498
Outdated
@@ -0,0 +1,7 @@ | |||
Bugfix: PDF display issue - Update CSP object-src policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please give the changelog file a proper title though? Something like bugfix-oc10-pdf-display
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 7b27c7c @JammingBen
Kudos, SonarCloud Quality Gate passed! |
Description
Using Owncloud Web 6.0.0, it is not possible to display a PDF using PDF Viewer cause the CSP is too restrictive.
It returns :
Related Issue
Motivation and Context
PDF will be working on Firefox out of the box.
How Has This Been Tested?
Old owncloud server running, updated to 10.11; added new configuration to support OwnCloud Web new front-end.
Screenshots (if appropriate):
Before :
![image](https://user-images.githubusercontent.com/85616869/218868731-66115eb7-0a72-4ef3-938c-4f61271966bb.png)
CSP configuration :
View :
![image](https://user-images.githubusercontent.com/85616869/218868452-ad322a68-0379-46f5-8829-0c3c68b725cf.png)
After, with updated CSP and visible PDF :
![image](https://user-images.githubusercontent.com/85616869/218869549-baab4878-9c95-4169-95a5-f3afa5c4ee72.png)
Types of changes
Checklist: