Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Pass globalProperties to routes and navItems of apps #8437

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Feb 15, 2023

Description

This PR passes globalProperties to routes and navItems, which gives apps the possibility to use those when defining their routes and navigation items.

This is a pre-requisite for #8431

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Feb 15, 2023
@update-docs
Copy link

update-docs bot commented Feb 15, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 💪

@JammingBen JammingBen changed the title Make permissionManager available for routes and navItems of apps Pass globalProperties to routes and navItems of apps Feb 15, 2023
@JammingBen JammingBen force-pushed the routes-nav-items-permission-manager branch from 5f181bd to 303b6eb Compare February 15, 2023 09:50
@JammingBen JammingBen changed the title Pass globalProperties to routes and navItems of apps [full-ci] Pass globalProperties to routes and navItems of apps Feb 15, 2023
@JammingBen JammingBen force-pushed the routes-nav-items-permission-manager branch from 303b6eb to 56bcf78 Compare February 15, 2023 10:22
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

34.8% 34.8% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 2561404 into master Feb 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the routes-nav-items-permission-manager branch February 15, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants