-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent file upload when folder creation failed #7975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcb1f83
to
75e65d2
Compare
Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/29901/37/1 💥 The oC10SharingPublic2 tests pipeline failed. The build has been cancelled. |
2d493d2
to
b1d550f
Compare
6 tasks
b1d550f
to
85eb7ad
Compare
85eb7ad
to
4052206
Compare
kulmann
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a typo in the changelog item, I can change that in another PR when I prepare the next rc tag.
changelog/unreleased/bugfix-file-upload-with-failed-folder-creation
Outdated
Show resolved
Hide resolved
dschmidt
approved these changes
Nov 17, 2022
packages/web-runtime/tests/unit/composables/upload/useUpload.spec.ts
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
This was referenced Nov 18, 2022
73 tasks
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've fixed a bug where files would try to be uploaded if the creation of their respective folder failed beforehands.
Also improved the tests a bit:
CreateAndUpload
to TypeScriptRelated Issue
Screenshots
Types of changes