-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origin checks to all Draw.io events #7941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
commented
Nov 9, 2022
@@ -64,7 +64,7 @@ export default defineComponent({ | |||
watch: { | |||
currentFileContext: { | |||
handler: function () { | |||
this.load() | |||
this.checkPermissions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi No need to call load()
here, it will be called later anyways. checkPermissions()
is sufficient.
dschmidt
reviewed
Nov 9, 2022
AlexAndBear
approved these changes
Nov 9, 2022
f7a325c
to
3c72457
Compare
dschmidt
reviewed
Nov 10, 2022
dschmidt
approved these changes
Nov 10, 2022
kulmann
suggested changes
Nov 14, 2022
kulmann
approved these changes
Nov 14, 2022
Kudos, SonarCloud Quality Gate passed! |
73 tasks
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Origin checks have been added to all Draw.io events due to security reasons.
Related Issue
Types of changes