Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable change user name #7919

Merged
merged 8 commits into from
Feb 16, 2023
Merged

Enable change user name #7919

merged 8 commits into from
Feb 16, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 4, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Nov 4, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Enable rename user Enable user renaming Nov 4, 2022
@AlexAndBear AlexAndBear marked this pull request as draft November 4, 2022 06:29
@AlexAndBear
Copy link
Contributor Author

Change user name is not supported by backend currently:

{"error":{"code":"notSupported","innererror":{"date":"2022-11-04T06:29:42Z","request-id":"62af0378-0f36-4f6c-aa63-165092c2f33b"},"message":"changing the user name is currently not supported"}}

@AlexAndBear AlexAndBear changed the title Enable user renaming Enable change user name Nov 4, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/29623/74/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear requested a review from kulmann February 14, 2023 14:42
@AlexAndBear AlexAndBear marked this pull request as ready for review February 15, 2023 09:38
@AlexAndBear AlexAndBear self-assigned this Feb 16, 2023
@AlexAndBear AlexAndBear mentioned this pull request Feb 16, 2023
Closed
JammingBen
JammingBen suggested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, rest LGTM

packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue Outdated Show resolved Hide resolved
JammingBen
JammingBen approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (needs a linter run though)

kulmann
kulmann approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

packages/web-app-admin-settings/src/components/Users/CreateUserModal.vue
return false
} catch (e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my IDE usually hints to name the error variable ignored in such cases :-) but up to you, e is also fine

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/32858/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32858/tracing/copy-and-move-resources-in-personal-space-alice-2023-2-16-10-57-05.zip

💥 The e2e-ocis tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.0% 78.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 07be70a into master Feb 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the issues/7604 branch February 16, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen JammingBen approved these changes

Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @ownclouders @kulmann @JammingBen