Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split (in)direct link shares in sidebar into two lists #7140

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Split (in)direct link shares in sidebar into two lists #7140

merged 1 commit into from
Jun 21, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter requested a review from fschade as a code owner June 17, 2022 16:08
@pascalwengerter pascalwengerter force-pushed the sidebar-shares-split-indirect-links branch from 3686501 to 27de808 Compare June 17, 2022 16:40
@pascalwengerter pascalwengerter force-pushed the sidebar-shares-split-indirect-links branch from 27de808 to f852386 Compare June 20, 2022 09:11
@pascalwengerter pascalwengerter requested a review from kulmann June 20, 2022 09:17
@pascalwengerter pascalwengerter changed the title Split (in)direct link shares in sidebar in two lists Split (in)direct link shares in sidebar into two lists Jun 20, 2022
tbsbdr
tbsbdr suggested changes Jun 20, 2022
View reviewed changes
Copy link

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All indirect links should be collapsed initially otherwise the right sidebar welcomes the user quite crowded (presumably).

@pascalwengerter
Copy link
Contributor Author

All indirect links should be collapsed initially otherwise the right sidebar welcomes the user quite crowded (presumably).

They are initially collapsed (not in the dockerized environment since that mirrors the CI behavior). PR needs a rebase though

tbsbdr
tbsbdr reviewed Jun 20, 2022
View reviewed changes
Copy link

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pascalwengerter pascalwengerter force-pushed the sidebar-shares-split-indirect-links branch from f852386 to da33334 Compare June 21, 2022 08:34
@pascalwengerter
Copy link
Contributor Author

lgtm

You'll need to add an "approving" review, a simple lgtm comment doesn't overwrite the changes you requested before 😉

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.0% 63.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pascalwengerter pascalwengerter merged commit 6c6ddf0 into master Jun 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the sidebar-shares-split-indirect-links branch June 21, 2022 09:33
@micbar micbar mentioned this pull request Jun 22, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbsbdr tbsbdr tbsbdr approved these changes

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharing-Panel: Indirect links mess up the "Share via link"-Section
3 participants
@pascalwengerter @kulmann @tbsbdr