Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "share with people" overflow #6984

Merged
merged 2 commits into from
May 17, 2022
Merged

Fix "share with people" overflow #6984

merged 2 commits into from
May 17, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 16, 2022 •
edited
Loading

Description

Fix overflow of too long user name / display name
image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented May 16, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/25615/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear mentioned this pull request May 17, 2022
Closed
10 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear changed the title add overflow wrap Fix "share with people" overflow May 17, 2022
@AlexAndBear AlexAndBear marked this pull request as ready for review May 17, 2022 07:37
pascalwengerter
pascalwengerter approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does this mean we can close owncloud/owncloud-design-system#2006?

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented May 17, 2022 •
edited
Loading

I think so, any strong opinion @dschmidt ?

@AlexAndBear AlexAndBear merged commit 5c501ce into master May 17, 2022
@kulmann kulmann mentioned this pull request May 25, 2022
Closed
25 tasks
@pascalwengerter pascalwengerter deleted the issues/6004/follow-up branch June 29, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Components in the taskbar are hidden
3 participants
@AlexAndBear @ownclouders @pascalwengerter