Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: view options position #5493

Merged
merged 1 commit into from
Jul 12, 2021
Merged

fix: view options position #5493

merged 1 commit into from
Jul 12, 2021

Conversation

LukasHirt
Copy link
Collaborator

image

@LukasHirt LukasHirt added the Type:Bug Something isn't working label Jul 9, 2021
@LukasHirt LukasHirt self-assigned this Jul 9, 2021
@LukasHirt LukasHirt requested a review from fschade as a code owner July 9, 2021 08:56
@LukasHirt LukasHirt linked an issue Jul 9, 2021 that may be closed by this pull request
View button is left aligned in most views #5437
Closed
@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17221/49/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/17294/38/1
The following scenarios passed on retry:

  • webUISharingExternal/federationSharing.feature:364

@pascalwengerter pascalwengerter merged commit a6ff6cf into master Jul 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/view-button-position branch July 12, 2021 08:34
@fschade fschade mentioned this pull request Jul 12, 2021
Closed
@micbar micbar mentioned this pull request Jul 13, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@LukasHirt LukasHirt

Labels
Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View button is left aligned in most views
3 participants
@LukasHirt @ownclouders @pascalwengerter