Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract loadPreview into helper #5426

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jun 30, 2021

Description

in the past loadPreview only was needed from within vuex store, with the upcoming preview feature and search // filter it is required to be able to use preview loading outside the store too. This pr utilize loadPreview and make it available as a helper.

Related Issue

Motivation and Context

extract more and more logic out of vuex

How Has This Been Tested?

  • local installation and unit tests
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@fschade fschade added the Status:Needs-Review Needs review from a maintainer label Jun 30, 2021
@fschade fschade self-assigned this Jun 30, 2021
@update-docs
Copy link

update-docs bot commented Jun 30, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16974/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oC10Basic https://drone.owncloud.com/owncloud/web/16974/6/1
The following scenarios passed on retry:

  • webUIPreview/imageMediaViewer.feature:35

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@pascalwengerter pascalwengerter merged commit be1317c into master Jun 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the extract-load-preview branch June 30, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants