Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add view options #5408

Merged
merged 5 commits into from
Jun 29, 2021
Merged

feat: add view options #5408

merged 5 commits into from
Jun 29, 2021

Conversation

LukasHirt
Copy link
Collaborator

Add view options dropdown above files list with toggle for hidden files visibility. All changes are persisted in the local storage. Since we cannot access vuex-persist plugin from extensions, I have saving values to the storage on my own.

image

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jun 28, 2021
@LukasHirt LukasHirt self-assigned this Jun 28, 2021
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good so far, only integration tests failing in CI and a super nitpicky change request

packages/web-app-files/src/components/AppBar/AppBar.vue Outdated Show resolved Hide resolved
@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@LukasHirt LukasHirt force-pushed the feat/view-options branch from 63e9bc4 to 52184e7 Compare June 29, 2021 10:52
@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment regarding aria-label for the button

Also, with batch actions displayed on small screens it's currently suboptimal (lack of spacing)

Screenshot 2021-06-29 at 12-22-56 Gelöschte Dateien - ownCloud

packages/web-app-files/src/components/AppBar/AppBar.vue Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16941/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎯 sonarcloud bug can be ignored in this case since it fails to understand the Vue component in question

@LukasHirt LukasHirt merged commit bcb9e62 into master Jun 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/view-options branch June 29, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants