-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add view options #5408
feat: add view options #5408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good so far, only integration tests failing in CI and a super nitpicky change request
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
63e9bc4
to
52184e7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarCloud Quality Gate failed. |
Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16941/47/1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎯 sonarcloud bug can be ignored in this case since it fails to understand the Vue component in question
Add view options dropdown above files list with toggle for hidden files visibility. All changes are persisted in the local storage. Since we cannot access vuex-persist plugin from extensions, I have saving values to the storage on my own.