Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] Wrong type in config.php value #5404

Merged
merged 1 commit into from
Jun 28, 2021
Merged

[docs-only] Wrong type in config.php value #5404

merged 1 commit into from
Jun 28, 2021

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 28, 2021

Description

Fix wrong type in the docs

'web.rewriteLinks' => 'true',
'web.rewriteLinks' => true,

I will not have an effect because 'true' is not false (it is just a string with the word "true") but semantically it is incorrect.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Docs

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 28, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar requested a review from pmaier1 June 28, 2021 08:57
pascalwengerter
pascalwengerter approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔍

@micbar micbar changed the title Wrong type in config.php value [docs-only] Wrong type in config.php value Jun 28, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16887/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

pmaier1
pmaier1 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmaier1 pmaier1 merged commit 2d4eaeb into master Jun 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-docs branch June 28, 2021 10:12
ownclouders pushed a commit that referenced this pull request Jun 28, 2021
@pmaier1
commit 2d4eaeb
d1ea272 
Merge: 274ea6b e48caaf
Author: Patrick Maier <[email protected]>
Date:   Mon Jun 28 12:12:29 2021 +0200

    Merge pull request #5404 from owncloud/fix-docs

    [docs-only]  Wrong type in config.php value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@pmaier1 pmaier1 pmaier1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micbar @ownclouders @pascalwengerter @pmaier1