Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the project's typescript version in vscode #10238

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

JammingBen
Copy link
Contributor

At least for me this causes much less issues in vscode. Otherwise it would use typescript 5.3 which is not yet compatible with Web.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Dec 22, 2023
Copy link

update-docs bot commented Dec 22, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@@ -13,7 +13,6 @@
},
"editor.formatOnSave": true,
"eslint.format.enable": true,
"eslint.packageManager": "pnpm",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi this is deprecated and is now being detected automatically.

@JammingBen JammingBen force-pushed the vscode-project-ts-version branch from 65acae8 to 8ba4f11 Compare December 22, 2023 13:08
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JammingBen JammingBen merged commit d51ddb7 into master Dec 22, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the vscode-project-ts-version branch December 22, 2023 13:47
ownclouders pushed a commit that referenced this pull request Dec 22, 2023
chore: use the project's typescript version in vscode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants