Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection: Preview app #7979

Closed
2 tasks
kulmann opened this issue Nov 16, 2022 · 6 comments
Closed
2 tasks

Collection: Preview app #7979

kulmann opened this issue Nov 16, 2022 · 6 comments
Assignees
Labels
Type:Epic Epic is the parent of user stories

Comments

@kulmann
Copy link
Contributor

kulmann commented Nov 16, 2022

This is a collection of upcoming improvements and fixes for the preview app

Bugs

Code cleanup

Enhancements

Accessibility

Tests

  • Increase unit test coverage
  • Check if it makes sense to increase e2e test coverage
@kulmann kulmann added the Type:Epic Epic is the parent of user stories label Nov 16, 2022
@dschmidt
Copy link
Member

dschmidt commented Dec 13, 2022

@pasnox
Copy link

pasnox commented Dec 23, 2022

Make it possible to play / stream video as well, that kind of missing :)

@dschmidt
Copy link
Member

Make it possible to play / stream video as well, that kind of missing :)

What exactly do you mean? The preview app can play videos, if they are supported by your browser. Do you have any counter-examples?

@kulmann
Copy link
Contributor Author

kulmann commented Dec 24, 2022

Only mp4 has playback options as we're relying on the native browser playback. I don't want to introduce a js lib for video playback at the moment. Backend side transcoding videos to h264 would be awesome for the preview app.

@pascalwengerter
Copy link
Contributor

@kulmann I'd suggest we close this issue? The two open ones stand for themselves

@kulmann
Copy link
Contributor Author

kulmann commented Aug 19, 2024

@kulmann I'd suggest we close this issue? The two open ones stand for themselves

Yep, true.

Thanks @AlexAndBear for building most of the stuff! 😍

@kulmann kulmann closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Epic Epic is the parent of user stories
Projects
None yet
Development

No branches or pull requests

5 participants