Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up media viewer code #3821

Closed
LukasHirt opened this issue Jul 24, 2020 · 2 comments · Fixed by #5900 or #8806
Closed

Clean up media viewer code #3821

LukasHirt opened this issue Jul 24, 2020 · 2 comments · Fixed by #5900 or #8806

Comments

@LukasHirt
Copy link
Collaborator

The media viewer is code is quite a mess. It would be better to split it into smaller components (proposal: Video player, photos viewer, controls). Also, it assumes in most names that the media is only an image.

@kulmann
Copy link
Contributor

kulmann commented Aug 13, 2020

We already took care of the naming in #3833

@pascalwengerter
Copy link
Contributor

Didn't break it up into more components and there's still cleanup to do, reopening this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants