Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional web config for css, scripts and translations #6032

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Apr 11, 2023

Description

This PR adds three key/value pairs to the config struct of the web service that reflect the status quo of config.json options:

  • styles for loading additional css
  • scripts for loading additional scripts
  • customTranslations for overwriting translations as needed

Related Issue

Motivation and Context

  • Make it possible to define styles/scripts/customTranslations via config/env vars
  • Stop kicking out the three key/value pairs when parsing a dedicated config.json file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann force-pushed the web-config-additions branch from f876a42 to 34c588b Compare April 11, 2023 22:02
@kulmann kulmann self-assigned this Apr 11, 2023
@kulmann kulmann mentioned this pull request Apr 11, 2023
10 tasks
@ownclouders
Copy link
Contributor

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit 7cb9e37 into master Apr 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the web-config-additions branch April 13, 2023 15:20
ownclouders pushed a commit that referenced this pull request Apr 13, 2023
feat: additional web config for css, scripts and translations
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants