Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Bump core commit 20200902 #514

Merged
merged 4 commits into from
Sep 3, 2020
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 2, 2020

  1. adjust the core commit id
    Gets test changes in core API tests:
    [Tests-Only] Improve error reporting for various tests core#37865 [Tests-Only] Improve error reporting for various tests
    [Tests-Only] Enable Provisioning Api Tests for OCIS core#37866 [Tests-Only] Enable Provisioning Api Tests for OCIS
    [Tests-Only] Run multiple tests for trashbinFilesFolders core#37863 [Tests-Only] Run multiple tests for trashbinFilesFolders
    [Tests-Only] Improve acceptance test error handling core#37868 [Tests-Only] Improve acceptance test error handling
    [Tests-Only] Fix case of tag notToImplementOnOCIS core#37871 [Tests-Only] Fix case of tag notToImplementOnOCIS
    [Tests-Only] subadmin and app-enable-disable-list are notToImplementOnOCIS core#37873 [Tests-Only] subadmin and app-enable-disable-list are notToImplementOnOCIS
    [Tests-Only] Fix add users in provisioning api when testing on ocis core#37874 [Tests-Only] Fix add users in provisioning api when testing on ocis

Note: this should wait for improved code for "Enable Provisioning Api Tests for OCIS" #512 and that will reduce the number of Provisioning API scenarios that need to be added to expected-failures.

  1. adjust the line numbers of trashbinFilesFolders scenarios that changed

  2. Do not run comments, federation, notifications, systemtags tests - these features do not exist yet. They are already tagged nicely in core. We can easily avoid running any of these test scenarios for now. And we can easily start running them by removing the filtering tag when the feature starts being implemented. This will allow us to remove more toImplementOnOCIS tags in core, and be able to switch these features on in the testing in each ocis-reva repo when we want to.

@phil-davis phil-davis self-assigned this Sep 2, 2020
@phil-davis phil-davis mentioned this pull request Sep 2, 2020
2 tasks
@phil-davis phil-davis force-pushed the bump-commit-id-20200902 branch 4 times, most recently from fdb4323 to d0b2320 Compare September 2, 2020 15:49
@phil-davis phil-davis marked this pull request as ready for review September 3, 2020 03:03
@phil-davis phil-davis merged commit ba3eb48 into master Sep 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-id-20200902 branch September 3, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants