change default log level to error #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkloucek
force-pushed
the
default_log_level_error
branch
from
a354009 to
137d097
Compare
C0rby
reviewed
Feb 1, 2022
ocis-pkg/log/log.go
Outdated
| @@ -58,7 +58,7 @@ func NewLogger(opts ...Option) Logger { | |||
| zerolog.SetGlobalLevel(zerolog.DebugLevel) | |||
| mlog.SetLevel(mlog.LevelTrace) | |||
| default: | |||
| zerolog.SetGlobalLevel(zerolog.InfoLevel) | |||
| zerolog.SetGlobalLevel(zerolog.ErrorLevel) | |||
| mlog.SetLevel(mlog.LevelInfo) | |||
There was a problem hiding this comment.
Should this also be changed to the error level?
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default log level is now "error"