Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cs3 users deployment example #2643

Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix cs3 users deployment example #2643

merged 1 commit into from
Oct 20, 2021

Conversation

wkloucek
Copy link
Contributor

Description

Currently the CS3 users deployment example does not work on our continuous deployment since OCIS_DOMAIN is missing for the web config.json templating.

Therefore we have https://ocis.owncloud.test in the config.json, even if the domain is different: https://ocis.ocis-cs3-users.latest.owncloud.works/config.json

@update-docs
Copy link

update-docs bot commented Oct 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from rhafer October 19, 2021 16:22
@wkloucek wkloucek mentioned this pull request Oct 19, 2021
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek requested a review from refs October 20, 2021 06:25
@wkloucek wkloucek changed the title fix cs3 users deploymente example fix cs3 users deployment example Oct 20, 2021
@wkloucek wkloucek merged commit 60a68e8 into master Oct 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the deployment-example-fix-cs3-users branch October 20, 2021 13:05
ownclouders pushed a commit that referenced this pull request Oct 20, 2021
@wkloucek
commit 60a68e8
83b5c99 
Merge: 33649ef c846646
Author: Willy Kloucek <[email protected]>
Date:   Wed Oct 20 15:05:20 2021 +0200

    Merge pull request #2643 from owncloud/deployment-example-fix-cs3-users

    fix cs3 users deployment example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @rhafer