Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update token manager with scopes functionality and update reva to v1.7.1-0.20210507091342-28500a8e0bb4 #2032

Closed
wants to merge 2 commits into from

Conversation

ishank011
Copy link
Contributor

@ishank011 ishank011 commented May 7, 2021

We introduced a breaking change in reva's token manager cs3org/reva#1669 and since ocis uses it directly, the method calls needed to be updated.

cc @micbar @butonic

@ishank011 ishank011 force-pushed the auth-token-scope branch from 71d8a30 to 2559725 Compare May 7, 2021 09:46
@micbar micbar added the Status:Needs-Review Needs review from a maintainer label May 7, 2021
@micbar
Copy link
Contributor

micbar commented May 7, 2021

@ishank011 Thanks for taking care.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

21.1% 21.1% Coverage
25.8% 25.8% Duplication

@ishank011 ishank011 requested a review from labkode May 7, 2021 10:00
@ishank011 ishank011 closed this May 17, 2021
@ishank011 ishank011 deleted the auth-token-scope branch May 17, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early-Adopter:CERN Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants