-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use service names #301
use service names #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work with the upcoming 3.0.0 release?
with the 3.1.0 AFAICT |
Ok, then we need to have this on a separate branch. Something like "next". We didn't yet release a chart version with oCIS 3.0.0. |
@butonic I changed the base to the "next" branch, so that we can release a chart compatible to ocis 3.0.0 on the master branch. |
@butonic release 0.3.0 of this Helm chart with oCIS 3.0.0 support was made. When you'll bump the appVersion in the Chart.yaml to something like 3.1.0-alpha.1 (when the oCIS tag is available), we can merge this PR directly to the master branch 👍 |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
I had a discussion with @ainmosni about #292 and our consent was that oCIS 3.1.0 related stuff should stay on the |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
switch to service names to make use of go micro registry