Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use service names #301

Merged
merged 3 commits into from
Jun 9, 2023
Merged

use service names #301

merged 3 commits into from
Jun 9, 2023

Conversation

butonic
Copy link
Member

@butonic butonic commented Jun 6, 2023

switch to service names to make use of go micro registry

Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with the upcoming 3.0.0 release?

@butonic
Copy link
Member Author

butonic commented Jun 6, 2023

with the 3.1.0 AFAICT

@wkloucek
Copy link
Contributor

wkloucek commented Jun 6, 2023

with the 3.1.0 AFAICT

Ok, then we need to have this on a separate branch. Something like "next". We didn't yet release a chart version with oCIS 3.0.0.

@wkloucek wkloucek changed the base branch from master to next June 6, 2023 13:52
@wkloucek wkloucek self-requested a review June 6, 2023 13:52
@wkloucek wkloucek dismissed their stale review June 6, 2023 13:52

changed the base to "next" branch

@wkloucek
Copy link
Contributor

wkloucek commented Jun 6, 2023

@butonic I changed the base to the "next" branch, so that we can release a chart compatible to ocis 3.0.0 on the master branch.

@wkloucek wkloucek mentioned this pull request Jun 7, 2023
@wkloucek
Copy link
Contributor

wkloucek commented Jun 7, 2023

@butonic release 0.3.0 of this Helm chart with oCIS 3.0.0 support was made. When you'll bump the appVersion in the Chart.yaml to something like 3.1.0-alpha.1 (when the oCIS tag is available), we can merge this PR directly to the master branch 👍

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@wkloucek
Copy link
Contributor

wkloucek commented Jun 7, 2023

@butonic release 0.3.0 of this Helm chart with oCIS 3.0.0 support was made. When you'll bump the appVersion in the Chart.yaml to something like 3.1.0-alpha.1 (when the oCIS tag is available), we can merge this PR directly to the master branch +1

I had a discussion with @ainmosni about #292 and our consent was that oCIS 3.1.0 related stuff should stay on the next branch for a week or two until we have oCIS 3.0.0 related stuff sorted out on the master branch

butonic added 2 commits June 8, 2023 23:00
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic merged commit 8476532 into next Jun 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the service-names branch June 9, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants