Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce per service settings #122

Merged
merged 3 commits into from
Nov 29, 2022
Merged

introduce per service settings #122

merged 3 commits into from
Nov 29, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 14, 2022

Description

Some settings cannot be configured on a global level and need to be exposed on a per service basis.

In this case:

  • resources

Related Issue

Motivation and Context

Add the possibility to properly configure oCIS for production deplyoments. One part of it is to assing resources to each services, so that it refects real work usage patterns.

How Has This Been Tested?

  • oCIS in minikube

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@wkloucek wkloucek force-pushed the per-service-settings branch from 2e836f3 to b71ae0b Compare November 16, 2022 08:25
@wkloucek wkloucek force-pushed the per-service-settings branch from b71ae0b to c161c7d Compare November 29, 2022 12:49
@wkloucek wkloucek marked this pull request as ready for review November 29, 2022 12:50
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wkloucek wkloucek merged commit 7b2bd76 into master Nov 29, 2022
@wkloucek wkloucek deleted the per-service-settings branch November 29, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants