Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] add api tests for accessing shares by id #38757

Merged
merged 1 commit into from
May 26, 2021
Merged

[Tests-Only] add api tests for accessing shares by id #38757

merged 1 commit into from
May 26, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented May 20, 2021 •
edited
Loading

Description

Add API tests for accessing shares by using share id, accepting and declining them.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@dpakach dpakach requested review from Talank, swoichha and saw-jan May 20, 2021 08:01
@dpakach dpakach self-assigned this May 20, 2021
@dpakach dpakach requested a review from jasson99 May 20, 2021 10:11
Talank
Talank reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix consecutive givens and whens

tests/acceptance/features/apiShareOperationsToShares/shareAccessByID.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareOperationsToShares/shareAccessByID.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareOperationsToShares/shareAccessByID.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareOperationsToRoot/shareAccessByID.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareOperationsToRoot/shareAccessByID.feature Outdated Show resolved Hide resolved
saw-jan
saw-jan reviewed May 20, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have this step which grammarly fits here

@dpakach dpakach requested a review from Talank May 21, 2021 05:12
@dpakach dpakach force-pushed the test-share-id-access branch from f3a8a0c to c2434d3 Compare May 21, 2021 05:12
@dpakach dpakach requested review from jasson99 and saw-jan May 21, 2021 05:12
saw-jan
saw-jan reviewed May 21, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Talank
Talank reviewed May 21, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasson99
jasson99 reviewed May 21, 2021
View reviewed changes
Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we have been leaving 2 lines between each scenario. Implementing the same style would make our work more uniform, I think.

@dpakach dpakach force-pushed the test-share-id-access branch from c2434d3 to 84df91a Compare May 26, 2021 06:18
@dpakach dpakach requested a review from individual-it May 26, 2021 06:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dpakach dpakach merged commit f95c362 into master May 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the test-share-id-access branch May 26, 2021 08:00
@dpakach dpakach mentioned this pull request May 27, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank left review comments

@jasson99 jasson99 jasson99 left review comments

@saw-jan saw-jan saw-jan left review comments

@individual-it individual-it individual-it approved these changes

@swoichha swoichha Awaiting requested review from swoichha

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@dpakach dpakach

Labels
3 - To Review dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dpakach @phil-davis @individual-it @Talank @jasson99 @saw-jan