Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐝 (svg tester) prettify SVG files #4643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Mar 7, 2025

When working with the SVG tester, it is sometimes not clear what changed from looking at the pictures. It can then be helpful to look at the text diff, but this is not straightforward since the SVGs are on a single line.

This PR prettifies SVGs before comparison. The SVG tester doesn't fail on this branch because it prettifies both, the original and the new one, and then compares them.

We should update the SVG tester anyway because of the includedEntities -> includedEntityNames change, so I'll do that after merging this PR.

@github-actions github-actions bot added the staging-viz Let SVG tester fail silently in CI label Mar 7, 2025
@owidbot
Copy link
Contributor

owidbot commented Mar 7, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-prettify-svg-files

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-03-07 16:01:44 UTC
Execution time: 1.26 seconds

@sophiamersmann sophiamersmann marked this pull request as ready for review March 7, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants