fix(grapher refactor): fix time param handling #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the SVG diffs present in #4419, hopefully.
Reason being that
legacyConfigAsAuthored.minTime == undefined, whereasauthorsVersion.minTime == -Infinity(since it's explicitly set in theGrapherState#constructor -> updateFromObjectcall).You explicitly changed this in the PR - maybe to circumvent some sort of circular dependency that occurred at some point? Anyhow, it seems this is now safe to do.
Decided to add a test for it, too, for which I had to make the getter public.