🐛 (admin) prevent infinite loop when loading variables / TAS-859 #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid dimensions lead to an infinite loop where variables are loaded again and again in the admin
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-03-05 16:00:14 UTC |
sophiamersmann
force-pushed
the
fix-admin-infinite-loading
branch
from
4c0cb2d to
9f99b42
Compare
sophiamersmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid dimensions lead to an infinite loop where variables are loaded again and again in the admin
This appears to be fixed in the Grapher state refactor, so I'm closing this one down.Might still makes sense to fix this now since the refactor only ships in 6 to 8 weeks?Example: live / staging