Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed assert() usage #3202

Merged
merged 8 commits into from
Aug 18, 2024
Merged

Fixed assert() usage #3202

merged 8 commits into from
Aug 18, 2024

Conversation

marcstern
Copy link

  • added some missing
  • removed some invalid
  • removed some that were not relevant in the context of the current function, when done in a called function

 - added some missing
 - removed some invalid
 - removed some that were not relevant in the context of the current function, when done in a called function
apache2/apache2_config.c Show resolved Hide resolved
@marcstern marcstern added the 2.x Related to ModSecurity version 2.x label Aug 7, 2024
Copy link
Member

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some removed and still missing check.

apache2/apache2_config.c Show resolved Hide resolved
apache2/apache2_config.c Show resolved Hide resolved
apache2/apache2_config.c Show resolved Hide resolved
apache2/apache2_config.c Show resolved Hide resolved
apache2/apache2_config.c Show resolved Hide resolved
apache2/re_operators.c Show resolved Hide resolved
apache2/re_operators.c Show resolved Hide resolved
apache2/re_operators.c Show resolved Hide resolved
apache2/re_operators.c Show resolved Hide resolved
apache2/re_operators.c Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@airween airween merged commit e7e11d9 into owasp-modsecurity:v2/master Aug 18, 2024
40 of 41 checks passed
airween added a commit to airween/ModSecurity that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants