Wait before closing socket on fatal error #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some very specific cases, messages can be lost when closing the socket, meaning the game would crash without showing the fatal error message.
I'm using Thread.Sleep but I felt like it was alright since it's only for shutting down the game. Any better way to wait?
I tried a lot of other stuff to make the socket close gracefully without failing to send a message, but for whatever reason none of it worked. It only seems to be a problem with the mod manager, so I suspect it is a problem with node closing the socket too soon on that side, but I had no luck fixing the problem in the manager's end.