Improved combination input UI, OWML config menu, refactoring of menu code #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0df8464.
Revert "Launch game with OpenVR flag if VR is required"
* moved CommandLineArguments.cs to ModHelper
* common base class for ModButton and ModLayoutButton * sharing methods for adding and getting buttons
input command handlers
* added command to event signatures * made it possible to assign multiple commands Co-authored-by: Aleksandr <[email protected]>
* cleanup up base config menu * introduced default config for owml * common base class for ModConfigMenu and OwmlConfigMenu. removes hacky code (#153) * creating config file from default if missing
merged ModsMenu's initializers
fixed removal in invokes
Streamlined ModsMenu.Initialize()
made Console protected in menus
* implemented menus for setting input combinations * Changed behaviour of combination collision checking, now it works a bit better * Made most GetComponentInChildren check inactive objects * gotta block next OnRelease as a preparation for some stuff switching to OnNewlyReleased Co-authored-by: Ricardo Lopes <[email protected]> Co-authored-by: AmazingAlek <[email protected]>
* added IsSelected to ModInput and ModButton * added common parents where it made sense
* Implemented ModPromptButton
* gathered all file reading/writing to one place
|
|
* made PromptButton inherit TitleButton changed some stuff in ModMenu to properly handle PromptButtons * Alek's suggestions * Alek's suggestion
fixed error from pipeline (there was GUID of TAIcheat still in there)
* made PromptButton inherit TitleButton changed some stuff in ModMenu to properly handle PromptButtons * Alek's suggestions * Now Menus react to buttons a bit nicer :3 * Fixed some bugs I found while testing * fixed incorrect merge Alek's suggestion currently looking at `using`s * removed no longer needed `using`s in modified files
* Now ModPopupInputs properly react to buttons
* static GameObject -> Object (just to remove warnings)
* removed unnessessary property
|
Todo for release:
|
|
part 2 is done 😋 |
* sacrifice ControllerButton for a better code :P Co-authored-by: AmazingAlek <[email protected]>
* fix conflicting bindings in Combination editor menu
* I hate it, but it works Co-authored-by: Aleksander Waage <[email protected]>
* Fixed minor bug when registering game's bindings * made it possible to have colliding combinations * more graceful fail with invalid keys (shows empty keys in their place) * more readable warnings * just some stuff Co-authored-by: Aleksander Waage <[email protected]>
…if opened by mouse
…Properly made sure PopupInput will be reselected after Popup gets closed
* Fix duplicate mod errors and fix dependency errors, simplified a lot of the dependency checking code
* removed a hack \o/ * Tai/fix combination menu (#202) * CombinationMenu gets initialized only once (#203) Co-authored-by: Aleksandr <[email protected]>
added .Show
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a lot of testing...