Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extract_lastnight.sh to read from /lustre/pipeline/night-time #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update extract_lastnight.sh to read from /lustre/pipeline/night-time #70

wants to merge 1 commit into from

Conversation

isella
Copy link

@isella isella commented May 23, 2024

No description provided.

caseyjlaw
caseyjlaw reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@caseyjlaw caseyjlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you have decided that a new path is appropriate. Can you also add a test to confirm that there are files present? Currently, the script fails if no files are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyjlaw caseyjlaw caseyjlaw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isella @caseyjlaw