Address https://github.com/ovro-lwa/lwa-issues/issues/486#issuecommen… #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-1927325521 The X-engine baseline selection happens on a per-polarization level - i.e. it is possible to select baselines of arbitrary polarization, e.g. all XX pols. The fast correlator output has two packet formats, one allows arbitrary selection while the other is COR-standard and assumes that each packet contains data from all 4 polarization-products of a station pair. If using this output format (which the LWA-OVRO correlator typically does) the baselines selected are assumed to be in sets of 4 where each 4 consecutive baselines are the 4 pol-pairs of a single station pair. In this case, the 4 baselines selected must match the polarization order expeted by the COR format.
|
LGTM. I’m sure someone will test it
…On Monday, February 5, 2024, Jack Hickish ***@***.***> wrote:
@jack-h <https://github.com/jack-h> requested your review on: #56
<#56> Address
ovro-lwa/lwa-issues#486 (comment)….
—
Reply to this email directly, view it on GitHub
<#56 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADYTNEO32KZO7HAOFOTWSUTYSECN5AVCNFSM6AAAAABC2OKLFKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG4YDMNZSGYZDENI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
caseyjlaw
approved these changes
Feb 5, 2024
|
@jaycedowell Can you confirm that the data recorder expects this order? If so, I'll deploy it for testing. |
|
Yep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t-1927325521
The X-engine baseline selection happens on a per-polarization level - i.e. it is possible to select baselines of arbitrary polarization, e.g. all XX pols. The fast correlator output has two packet formats, one allows arbitrary selection while the other is COR-standard and assumes that each packet contains data from all 4 polarization-products of a station pair.
If using this output format (which the LWA-OVRO correlator typically does) the baselines selected are assumed to be in sets of 4 where each 4 consecutive baselines are the 4 pol-pairs of a single station pair. In this case, the 4 baselines selected must match the polarization order expeted by the COR format.