Post metrics to datadog after rotation #276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code to post metrics to datadog after rotation.
It also logs errors from posting metrics in non-rotation mode. I'm on the fence about whether this is a good idea, as the current behaviour will call datadog even when the user hasn't set a metric name or authenticated, so this could make some people's implementations noisier. It still seems better to let them know what's going wrong, though.