Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tf module perms #274

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Improve tf module perms #274

merged 2 commits into from
Oct 23, 2020

Conversation

eversC
Copy link
Collaborator

@eversC eversC commented Oct 23, 2020

This moves us away from using the AWS managed IAMFullAccess and SecretsManagerReadWrite policies, and uses our own custom policy instead, giving the limited perms cloud-key-rotator requires for IAM and SSM.

I've tested this in a nonprod AWS account and looks good from that perspective.

A new variable enable_ssm_location has been introduced, as users won't always require the extra perm required to use SSM as an output location of cloud-key-rotator.

I bumped the module version from 0.0.6 to 0.1.0.

@eversC eversC requested a review from enicholson125 October 23, 2020 06:37
enicholson125
enicholson125 approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@enicholson125 enicholson125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eversC eversC merged commit 12b83a8 into master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enicholson125 enicholson125 enicholson125 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eversC @enicholson125