Treat 404 errors from Kubernetes API as missing values #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than relying on the message returned from the kubernetes api being exactly "Not Found" we now also treat HTTP code 404 as a missing configuration value. This is much more robust to changes as it is unlikely that the HTTP status code spec will change while kubernetes can decide to change the error message at any point in time.
|
This is a good change. Thanks for the PR! |
rmorais
pushed a commit
that referenced
this pull request
Nov 19, 2021
Rather than relying on the message returned from the kubernetes api being exactly "Not Found" we now also treat HTTP code 404 as a missing configuration value. This is much more robust to changes as it is unlikely that the HTTP status code spec will change while kubernetes can decide to change the error message at any point in time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than relying on the message returned from the kubernetes api
being exactly "Not Found" we now also treat HTTP code 404 as a
missing configuration value. This is much more robust to changes
as it is unlikely that the HTTP status code spec will change while
kubernetes can decide to change the error message at any point in
time.