Update to Ciris 2.x #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensraaby
reviewed
May 18, 2021
readme.md
Outdated
| ) | ||
| } | ||
| val config = | ||
| configMapInNamespace[IO]("pizza", blocker).flatMap { configMap => |
There was a problem hiding this comment.
I might have missed something, but where's the blocker coming from now?
There was a problem hiding this comment.
Blocker got removed from Cats-effect 3. I missed that entry on the readme. will fix it
There was a problem hiding this comment.
I should probably add mdoc so the readme would be compiled :)
|
There is a branch with some tests, where I spin up minikube and make sure everything works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this new major version of Ciris, they moved to use Cats-Effect 3.x, which is binary incompatible with previous versions.
This means, that we also need to provide a new major version for Ciris-kubernetes.
Support for ciris-kubernetes 1.x can continue on the new branch ciris-1.x