Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kel/pvj main javacodegen crccheck #664

Merged
merged 9 commits into from
Feb 8, 2018

Conversation

lausdahl
Copy link
Member

@lausdahl lausdahl commented Feb 6, 2018

This contains a change to the maven plugin for the code generator so it only re-generates if the input files change. The big change from current state is that it ALWAYS re-generate if there is a change oppose to writing to the log using the default level which is very difficult to detect.

@lausdahl lausdahl added the enhancement Not a bug, but nice to have label Feb 6, 2018
@lausdahl lausdahl requested a review from peterwvj February 6, 2018 13:56
@peterwvj peterwvj merged commit bb15b31 into development Feb 8, 2018
@peterwvj peterwvj deleted the kel/pvj-main-javacodegen-crccheck branch February 8, 2018 07:55
@peterwvj
Copy link
Member

peterwvj commented Feb 8, 2018

I tried this feature on some other project. It works well! Thanks a lot for this contribution @lausdahl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Not a bug, but nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants